Re: [PATCH] Add /proc/net/tcp_listen

[YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>]

In article <20040618043151.0483c158.ak@xxxxxxx> (at Fri, 18 Jun 2004 04:31:51 
+0200), Andi Kleen <ak@xxxxxxx> says:

>  int __init tcp4_proc_init(void)
>  {
> -     return tcp_proc_register(&tcp4_seq_afinfo);
> +     int err = tcp_proc_register(&tcp4_seq_afinfo);
> +     if (err) 
> +             return err;
> +     return tcp_proc_register(&tcp4_listen_seq_afinfo);
>  }
>  
>  void tcp4_proc_exit(void)
>  {
>       tcp_proc_unregister(&tcp4_seq_afinfo);
> +     tcp_proc_unregister(&tcp4_listen_seq_afinfo);
>  }
>  #endif /* CONFIG_PROC_FS */
>  

If you register A then B, it is better to unregister B then A (symmetric).
Yes, it does not matter in this case, but it is better coding style
since there often are dependencies.

--yoshfuji