Re: 2.6.7-rc3: unregister_netdevice: waiting for tun0 to become free. Usage count = 1

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Wed, Jun 16, 2004 at 01:47:11PM -0700, David S. Miller wrote:
> On Thu, 17 Jun 2004 00:37:48 +0400
> Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx> wrote:
> 
> > Sort of. I think it should happen after killing reference to dst->dev:
>  ...
> > but before dropping reference to dev:
>  ...
> > So, I think it should look like:
> > 
> >             dst->dev = &loopback_dev;
> >             dev_hold(&loopback_dev);
> > +           synchronize_kernel();
> >             dev_put(dev);
> 
> Perfect, that's what I put into my tree then, plus some comment.

Yes we definitely want this call.  But wouldn't it be better to do one
call at the top level, say at the end of netdev_wait_allrefs?

Otherwise we may end up with lots of synchronize_kernel() calls
scattered in each individual event handler.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt