| To: | Arthur Kepner <akepner@xxxxxxx> |
|---|---|
| Subject: | Re: [RFC/PATCH] lockless loopback patch for 2.6 (version 2) |
| From: | Mitchell Blank Jr <mitch@xxxxxxxxxx> |
| Date: | Mon, 14 Jun 2004 11:23:36 -0700 |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <Pine.SGI.4.56.0406141000060.479900@neteng.engr.sgi.com> |
| References: | <Pine.SGI.4.56.0406141000060.479900@neteng.engr.sgi.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.1i |
Arthur Kepner wrote:
> +#define HARD_TX_LOCK_BH(dev, cpu) { \
> + if ( dev->features && NETIF_F_LLTX == 0 ) { \
^^
Don't you mean '&' instead of '&&' here? It looks like that condition is
always false, so you've killed the TX locking for all devices with this
patch.
> + if ( dev->features && NETIF_F_LLTX == 0 ) { \
ditto
-Mitch
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] fix oops from acenic ethtool, Jeff Garzik |
|---|---|
| Next by Date: | Re: [RFC/PATCH] lockless loopback patch for 2.6 (version 2), Andi Kleen |
| Previous by Thread: | [RFC/PATCH] lockless loopback patch for 2.6 (version 2), Arthur Kepner |
| Next by Thread: | Re: [RFC/PATCH] lockless loopback patch for 2.6 (version 2), Arthur Kepner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |