| To: | "David S. Miller" <davem@xxxxxxxxxx> |
|---|---|
| Subject: | Re: Allow IP header alignment to be overriden |
| From: | Anton Blanchard <anton@xxxxxxxxx> |
| Date: | Sat, 12 Jun 2004 00:08:43 +1000 |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <20040610223549.5e9ad025.davem@redhat.com> |
| References: | <20040611012727.GA27672@krispykreme> <20040610223549.5e9ad025.davem@redhat.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040523i |
> This transformation is not valid for a lot of drivers, that "2" > in the reserve exists elsewhere in other calculations in the > drivers. For example, it is added to the RX skb allocation > size. Sometimes this '2' is there in non-trivial or hard to > see ways (ie. it's implicitly in some DMA alignment value) > > That's the only reason I'm against this patch. Yeah I started converting all drivers across to skb_align and quickly noticed that. We can instead convert drivers over as they are tested, the Gbit and 10Gbit cards being the most important. Ive tested the 2 10Gbit cards and one 1Gbit (e1000). I can test the acenic and should be able to hunt down a sungem and tg3. That leaves dl2K, myricom, ns83820, hamachi, yellowfin, r8169, and sk98lin which can be converted across as needed. Anton |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: UDP sockets bound to ANY send answers with wrong src ip address, Julian Anastasov |
|---|---|
| Next by Date: | Re: Allow IP header alignment to be overriden, Anton Blanchard |
| Previous by Thread: | Re: Allow IP header alignment to be overriden, David S. Miller |
| Next by Thread: | Re: Allow IP header alignment to be overriden, jamal |
| Indexes: | [Date] [Thread] [Top] [All Lists] |