Re: 4/x: [NETDRV] Merge register_netdev calls

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Thu, Jun 10, 2004 at 08:09:08PM -0400, Jeff Garzik wrote:
> 
> Unfortunately this and patch #5 are moving in the opposition direction 
> from what we want to be doing, I think.
> 
> AFAICS these patches move register_netdev() to points in each driver 
> earlier in the probe phase, when the driver is not fully set up and 
> ready to receive packets.
> 
> Am I missing something?

The only change made by these two patches is moving the call to
register_netdev() from the outer probe() function to the inner
probe() function where the the printk's are.

There is absolutely no code in between the two locations.  That is,
the driver would've immediately called register_netdev after the inner
probe() has succeeded.

In fact it's really making these ISA/MCA probe() functions more
like the ones we have for PCI.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt