| To: | Andi Kleen <ak@xxxxxxx> |
|---|---|
| Subject: | Re: Allow IP header alignment to be overriden |
| From: | Anton Blanchard <anton@xxxxxxxxx> |
| Date: | Fri, 11 Jun 2004 11:43:55 +1000 |
| Cc: | davem@xxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20040611013522.GA9809@wotan.suse.de> |
| References: | <20040611012727.GA27672@krispykreme> <20040611013522.GA9809@wotan.suse.de> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040523i |
> > +#ifndef ARCH_HAS_SKB_ALIGN > > +#define skb_align(SKB, LEN) skb_reserve((SKB), (LEN)) > > +#endif > > But where does this come from? There's no clear asm/ include in skbuff.h > matching it, and relying on indirect ones is probably not a good idea. Yeah I wasnt particularly happy about where I put the override. skbuff.h directly includes: #include <asm/atomic.h> #include <asm/types.h> ... #include <asm/system.h> system.h gets included way down in the file, so I picked system.h as the most reasonable of the three. Im open to ideas as to how to make this neater. Anton |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Allow IP header alignment to be overriden, Anton Blanchard |
|---|---|
| Next by Date: | Re: 4/x: [NETDRV] Merge register_netdev calls, Herbert Xu |
| Previous by Thread: | Re: Allow IP header alignment to be overriden, Andi Kleen |
| Next by Thread: | Re: Allow IP header alignment to be overriden, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |