| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | [PATCH] e1000 module parameters use new format |
| From: | Stephen Hemminger <shemminger@xxxxxxxx> |
| Date: | Wed, 9 Jun 2004 13:32:26 -0700 |
| Cc: | "Venkatesan, Ganesh" <ganesh.venkatesan@xxxxxxxxx>, cramerj <cramerj@xxxxxxxxx>, "Ronciak, John" <john.ronciak@xxxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <40C607D9.5090506@pobox.com> |
| Organization: | Open Source Development Lab |
| References: | <468F3FDA28AA87429AD807992E22D07E0158A1CD@orsmsx408> <20040608110420.3b93338d@dell_ss3.pdx.osdl.net> <40C607D9.5090506@pobox.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
The e1000 driver was mixing old/new module parameter methods. Okay, here is the other way to fix it by making the other module parameters the new format.. Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxx> diff -Nru a/drivers/net/e1000/e1000_param.c b/drivers/net/e1000/e1000_param.c --- a/drivers/net/e1000/e1000_param.c 2004-06-09 13:31:00 -07:00 +++ b/drivers/net/e1000/e1000_param.c 2004-06-09 13:31:00 -07:00 @@ -55,10 +55,11 @@ * over and over (plus this helps to avoid typo bugs). */ -#define E1000_PARAM(X, S) \ -static const int __devinitdata X[E1000_MAX_NIC + 1] = E1000_PARAM_INIT; \ -MODULE_PARM(X, "1-" __MODULE_STRING(E1000_MAX_NIC) "i"); \ -MODULE_PARM_DESC(X, S); +#define E1000_PARAM(name, desc) \ +static int __devinitdata name[E1000_MAX_NIC + 1] = E1000_PARAM_INIT; \ +static int num_##name = 0; \ +module_param_array(name, int, num_##name, 0); \ +MODULE_PARM_DESC(name, desc); /* Transmit Descriptor Count * |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Free software to help test qdiscs, Vincent Perrier |
|---|---|
| Next by Date: | Re: [IPV6] IP6CB, David S. Miller |
| Previous by Thread: | Re: [PATCH] e1000 module parameter incompatiablity, Stephen Hemminger |
| Next by Thread: | RE: [PATCH] e1000 module parameter incompatiablity, Venkatesan, Ganesh |
| Indexes: | [Date] [Thread] [Top] [All Lists] |