| To: | "Venkatesan, Ganesh" <ganesh.venkatesan@xxxxxxxxx> |
|---|---|
| Subject: | [PATCH] e1000 module parameter incompatiablity |
| From: | Stephen Hemminger <shemminger@xxxxxxxx> |
| Date: | Tue, 8 Jun 2004 11:04:20 -0700 |
| Cc: | "cramerj" <cramerj@xxxxxxxxx>, "Ronciak, John" <john.ronciak@xxxxxxxxx>, "Jeff Garzik" <jgarzik@xxxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <468F3FDA28AA87429AD807992E22D07E0158A1CD@orsmsx408> |
| Organization: | Open Source Development Lab |
| References: | <468F3FDA28AA87429AD807992E22D07E0158A1CD@orsmsx408> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
E1000 driver is mixing new style 'module_param' with old style 'MODULE_PARM'
this generates the runtime warning
e1000: Ignoring new-style parameters in presence of obsolete ones
and prevents using module parameters to set ring size.
Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxx>
diff -Nru a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
--- a/drivers/net/e1000/e1000_main.c 2004-06-08 11:01:58 -07:00
+++ b/drivers/net/e1000/e1000_main.c 2004-06-08 11:01:58 -07:00
@@ -202,8 +202,8 @@
MODULE_DESCRIPTION("Intel(R) PRO/1000 Network Driver");
MODULE_LICENSE("GPL");
-static int debug = 3;
-module_param(debug, int, 0);
+static int debug = NETIF_MSG_DRV | NETIF_MSG_PROBE;
+MODULE_PARM(debug, "i");
MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");
/**
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: RFC: Linux wireless extensions and WPA support, Jean Tourrilhes |
|---|---|
| Next by Date: | Re: e1000 w/ NAPI + SMP = 99% CPU utilization, Chris Carpinello |
| Previous by Thread: | [RFC] ethtool semantics, Roger Luethi |
| Next by Thread: | Re: [PATCH] e1000 module parameter incompatiablity, Jeff Garzik |
| Indexes: | [Date] [Thread] [Top] [All Lists] |