| To: | Andreas Schwab <schwab@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] compat bug in sys_recvmsg, MSG_CMSG_COMPAT check missing |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Sat, 5 Jun 2004 14:36:49 -0700 |
| Cc: | olh@xxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <jer7st7lam.fsf@sykes.suse.de> |
| References: | <20040605204334.GA1134@suse.de> <20040605140153.6c5945a0.davem@redhat.com> <20040605140544.0de4034d.davem@redhat.com> <jer7st7lam.fsf@sykes.suse.de> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Sat, 05 Jun 2004 23:21:53 +0200 Andreas Schwab <schwab@xxxxxxx> wrote: > "David S. Miller" <davem@xxxxxxxxxx> writes: > > > This means also that Olaf's patch is broken, when CONFIG_COMPAT is not > > set, MSG_CMSG_COMPAT is zero, thus ~MSG_CMSG_COMPAT is the unexpected > > value all 1's thus breaking the tests for unexpected flags completely. > > ??? Where do you get ~MSG_CMSG_COMPAT from? Olaf's patch, it said: - if (flags & ~(MSG_PEEK|MSG_DONTWAIT|MSG_TRUNC)) + if (flags & ~(MSG_PEEK|MSG_DONTWAIT|MSG_TRUNC|MSG_CMSG_COMPAT)) |
| Previous by Date: | [PATCH] compat bug in sys_recvmsg, MSG_CMSG_COMPAT check missing, Olaf Hering |
|---|---|
| Next by Date: | Re: [PATCH] compat bug in sys_recvmsg, MSG_CMSG_COMPAT check missing, David S. Miller |
| Previous by Thread: | Re: [PATCH] compat bug in sys_recvmsg, MSG_CMSG_COMPAT check missing, Andreas Schwab |
| Next by Thread: | Re: [PATCH] compat bug in sys_recvmsg, MSG_CMSG_COMPAT check missing, Andreas Schwab |
| Indexes: | [Date] [Thread] [Top] [All Lists] |