netdev
[Top] [All Lists]

Re: [PATCH] compat bug in sys_recvmsg, MSG_CMSG_COMPAT check missing

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] compat bug in sys_recvmsg, MSG_CMSG_COMPAT check missing
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Sat, 5 Jun 2004 14:05:44 -0700
Cc: olh@xxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040605140153.6c5945a0.davem@redhat.com>
References: <20040605204334.GA1134@suse.de> <20040605140153.6c5945a0.davem@redhat.com>
Sender: netdev-bounce@xxxxxxxxxxx
[ Replying to myself :-) ]

On Sat, 5 Jun 2004 14:01:53 -0700
"David S. Miller" <davem@xxxxxxxxxx> wrote:

> Let's ask a better question, why do we need to pass this thing down
> into the implementations anyways?

It's for net/core/scm.c handling, sigh.

This means also that Olaf's patch is broken, when CONFIG_COMPAT is not
set, MSG_CMSG_COMPAT is zero, thus ~MSG_CMSG_COMPAT is the unexpected
value all 1's thus breaking the tests for unexpected flags completely.

Any better ideas?

<Prev in Thread] Current Thread [Next in Thread>