netdev
[Top] [All Lists]

Re: [IPSEC] Fix xfrm_tunnel leak

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [IPSEC] Fix xfrm_tunnel leak
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Tue, 1 Jun 2004 12:35:42 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20040601122559.GA19761@gondor.apana.org.au>
References: <20040601122559.GA19761@gondor.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 1 Jun 2004 22:25:59 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> Turns out that the IPIP tunnel used by IPCOMP states are only freed
> if the IPCOMP state is deleted by xfrm_state_delete.
> 
> This is not the case for all states.  For example, an immature IPCOMP
> state that dies in add_sa will not go through xfrm_state_delete.
> 
> The following patch moves the delete_tunnel call into IPCOMP's
> destructor.  I think it makes more sense there as IPCOMP is the
> only user of the tunnel anyway.

Looks perfect, patch applied.

Thanks Herbert.

<Prev in Thread] Current Thread [Next in Thread>