netdev
[Top] [All Lists]

Re: Bug#251215: kernel-image-2.6.6-1-k7: pppd locks up, cannot be killed

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: Bug#251215: kernel-image-2.6.6-1-k7: pppd locks up, cannot be killed, during ppp shutdown
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 30 May 2004 06:04:16 +1000
Cc: debian.bugs@xxxxxxxxxxxxxxxx, 251215@xxxxxxxxxxxxxxx, shemminger@xxxxxxxx, jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040529125153.5f2df6ad.davem@redhat.com>
References: <20040529051736.GA11303@gondor.apana.org.au> <E1BU2WC-0003nd-00@gondolin.me.apana.org.au> <20040529125153.5f2df6ad.davem@redhat.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.5.1+cvs20040105i
On Sat, May 29, 2004 at 12:51:53PM -0700, David S. Miller wrote:
> On Sat, 29 May 2004 22:00:52 +1000
> Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > Here is a minimal fix for this problem.
> 
> Wouldn't it be easier just to move the "list_empty(&net_todo_list)"
> check to be inside the net_todo_run_mutex semaphore?

Yes that should work much better.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>