netdev
[Top] [All Lists]

Re: [PATCH] fix BUG in tg3_tx

To: "Michael Chan" <mchan@xxxxxxxxxxxx>
Subject: Re: [PATCH] fix BUG in tg3_tx
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Wed, 26 May 2004 11:47:14 -0700
Cc: gnb@xxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <B1508D50A0692F42B217C22C02D849727FEDBE@NT-IRVA-0741.brcm.ad.broadcom.com>
References: <B1508D50A0692F42B217C22C02D849727FEDBE@NT-IRVA-0741.brcm.ad.broadcom.com>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 26 May 2004 10:43:10 -0700
"Michael Chan" <mchan@xxxxxxxxxxxx> wrote:

> I would recommend tg3 to make the switch also.

Ok, I'll make it use DMA tx descriptors by default.

The checking for cases where we can't do on-chip TX desciptors
I'll keep around (albeit commented out) just in case we allow
this again in the future.

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/05/26 11:46:50-07:00 davem@xxxxxxxxxxxxxxxxxx 
#   [TG3]: Use HOST TXDs always.
# 
# drivers/net/tg3.c
#   2004/05/26 11:46:42-07:00 davem@xxxxxxxxxxxxxxxxxx +9 -0
#   [TG3]: Use HOST TXDs always.
# 
diff -Nru a/drivers/net/tg3.c b/drivers/net/tg3.c
--- a/drivers/net/tg3.c 2004-05-26 11:46:57 -07:00
+++ b/drivers/net/tg3.c 2004-05-26 11:46:57 -07:00
@@ -7534,6 +7534,14 @@
        udelay(50);
        tg3_nvram_init(tp);
 
+       /* Always use host TXDs, it performs better in particular
+        * with multi-frag packets.  The tests below are kept here
+        * as documentation should we change this decision again
+        * in the future.
+        */
+       tp->tg3_flags |= TG3_FLAG_HOST_TXDS;
+
+#if 0
        /* Determine if TX descriptors will reside in
         * main memory or in the chip SRAM.
         */
@@ -7541,6 +7549,7 @@
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705 ||
            GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750)
                tp->tg3_flags |= TG3_FLAG_HOST_TXDS;
+#endif
 
        grc_misc_cfg = tr32(GRC_MISC_CFG);
        grc_misc_cfg &= GRC_MISC_CFG_BOARD_ID_MASK;

<Prev in Thread] Current Thread [Next in Thread>