| To: | James Morris <jmorris@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH][SELINUX] 2/2 sock_create_lite() |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 7 May 2004 16:14:56 +0100 |
| Cc: | "David S. Miller" <davem@xxxxxxxxxx>, Stephen Smalley <sds@xxxxxxxxxxxxxx>, Chris Wright <chrisw@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, selinux@xxxxxxxxxxxxx |
| In-reply-to: | <Xine.LNX.4.44.0405071056300.21372-100000@thoron.boston.redhat.com>; from jmorris@redhat.com on Fri, May 07, 2004 at 11:06:04AM -0400 |
| Mail-followup-to: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, James Morris <jmorris@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>, Stephen Smalley <sds@xxxxxxxxxxxxxx>, Chris Wright <chrisw@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, selinux@xxxxxxxxxxxxx |
| References: | <Xine.LNX.4.44.0405071043540.21372@thoron.boston.redhat.com> <Xine.LNX.4.44.0405071056300.21372-100000@thoron.boston.redhat.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.2.5.1i |
On Fri, May 07, 2004 at 11:06:04AM -0400, James Morris wrote: > This patch adds a function sock_create_lite(), deprecating kernel-wide use > of sock_alloc(), which has been made static to net/socket.c. We're in the stable series and removing exported APIs there shoudn't happen. Given that sock_alloc() is actually okay for every normal use I don't think there's enough reason to remove it from the API. > +int sock_create_lite(int family, int type, int protocol, struct socket **res) Should probably be called __sock_create according to linux naming rules. Also I guess you should actually call it from sock_create instead of duplicating the code. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH][SELINUX] 2/2 sock_create_lite(), James Morris |
|---|---|
| Next by Date: | Re: [PATCH][SELINUX] 2/2 sock_create_lite(), James Morris |
| Previous by Thread: | [PATCH][SELINUX] 2/2 sock_create_lite(), James Morris |
| Next by Thread: | Re: [PATCH][SELINUX] 2/2 sock_create_lite(), James Morris |
| Indexes: | [Date] [Thread] [Top] [All Lists] |