| To: | Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2004@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] tulip driver deadlocks on device removal |
| From: | Pavel Machek <pavel@xxxxxxx> |
| Date: | Tue, 4 May 2004 16:11:28 +0200 |
| Cc: | Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Netdev <netdev@xxxxxxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxx> |
| In-reply-to: | <4096BBC8.60509@gmx.net> |
| References: | <4096BBC8.60509@gmx.net> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.3.27i |
Hi!
> If I remove the card, my machine freezes instantly. This is due to a
> stupid dev->poll function of the tulip driver.
>
> drivers/net/tulip/interrupt.c:tulip_poll() gets stuck in an endless loop
> in interrupt context if the hardware returns 0xffffffff on certain reads.
> But this is exactly what happens if you remove a pci device.
>
> My patch replaces the deadlock with something resembling a livelock. At
> least SysRq-S works now because we leave the poll function after some time.
Could you explicitely check for read returning 0xffffffff?
Pavel
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: TCP hangs, Mikulas Patocka |
|---|---|
| Next by Date: | Re: Prism54 2.6 kernel update, Luis R. Rodriguez |
| Previous by Thread: | [PATCH] tulip driver deadlocks on device removal, Carl-Daniel Hailfinger |
| Next by Thread: | [e100 2.6 1/2], Scott Feldman |
| Indexes: | [Date] [Thread] [Top] [All Lists] |