Re: [patch 0/7] 2.6.6-rc3-mm1 - description of the r8169 queue

[Francois Romieu <romieu@xxxxxxxxxxxxx>]

Andy Lutomirski <luto@xxxxxxxxxxxxx> :
[...]
> 3. NAPI is missing from Kconfig

It appears in patch 1/7 but it has not been included in the global patch
which is available online (fixed by now). This part of your patch should
be ignored. The remaining parts are fine.

> These patches also chance the initial chipset reset timer from 2 jiffies 
> to 100ms (for HZ-independence, and 2ms sounds overly short.)

Compared to the initial busy-looping, the 2ms timer did not look _that_
inefficient :o) As the reset is expected to take place in 0.5s at worst,
your change makes more sense.

--
Ueimor