| To: | ak@xxxxxxx |
|---|---|
| Subject: | Re: [PATCH] NETDEBUG network triggerable messages in IPv6 |
| From: | YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx> |
| Date: | Sat, 10 Apr 2004 02:18:40 +0900 (JST) |
| Cc: | davem@xxxxxxxxxx, netdev@xxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx |
| In-reply-to: | <20040409182125.348fd6cd.ak@suse.de> |
| Organization: | USAGI Project |
| References: | <20040409174847.2f0b7e77.ak@suse.de> <20040410.010051.129465789.yoshfuji@linux-ipv6.org> <20040409182125.348fd6cd.ak@suse.de> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
In article <20040409182125.348fd6cd.ak@xxxxxxx> (at Fri, 9 Apr 2004 18:21:25 +0200), Andi Kleen <ak@xxxxxxx> says: > > > This wraps all potentially network triggerable printks in IPv6 with > > > NETDEBUG. > > > > I really do NOT like this. Please, please do not do this. > > If you don't like it just keep NETDEBUG on. But for production systems being > able > to fill up logs from the network is not acceptable IMHO. Anyways default > behaviour > does not change right now, it just allows to easily disable all this cruft for > people who want that. I don't like the style; it is too ugly. E.g. please do not put "if () ..." into the macro argument. --yoshfuji |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] NETDEBUG network triggerable messages in IPv6, Andi Kleen |
|---|---|
| Next by Date: | Re: [PATCH] NETDEBUG network triggerable messages in IPv6, Andi Kleen |
| Previous by Thread: | Re: [PATCH] NETDEBUG network triggerable messages in IPv6, Andi Kleen |
| Next by Thread: | Re: [PATCH] NETDEBUG network triggerable messages in IPv6, Andi Kleen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |