Re: [PATCH] NETDEBUG network triggerable messages in IPv6

[YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>]

In article <20040409174847.2f0b7e77.ak@xxxxxxx> (at Fri, 9 Apr 2004 17:48:47 
+0200), Andi Kleen <ak@xxxxxxx> says:

> This wraps all potentially network triggerable printks in IPv6 with NETDEBUG.

I really do NOT like this. Please, please do not do this.

>               case ICMP_SR_FAILED:
> -                     if (net_ratelimit())
> +                     NETDEBUG(if (net_ratelimit())
>                               printk(KERN_INFO "ICMP: %u.%u.%u.%u: Source "
>                                                "Route Failed.\n",
> -                                    NIPQUAD(iph->daddr));
> +                                    NIPQUAD(iph->daddr)));

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@xxxxxxxxxxxxxx>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA