netdev
[Top] [All Lists]

Re: [PATCH][ATM]: [nicstar] using dev_alloc_skb() (reported by "Johnston

To: chas3@xxxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH][ATM]: [nicstar] using dev_alloc_skb() (reported by "Johnston, Jayme" <Jayme.Johnston@siemens.com>)
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Fri, 9 Apr 2004 16:38:18 -0700
Cc: chas@xxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <200404071211.i37CB3gK020805@ginger.cmf.nrl.navy.mil>
References: <200404071211.i37CB3gK020805@ginger.cmf.nrl.navy.mil>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 07 Apr 2004 08:11:04 -0400
"chas williams (contractor)" <chas@xxxxxxxxxxxxxxxx> wrote:

> the nicstar driver has typically used alloc_skb() to get its i/o buffers.
> since these buffers are likely to be passed to the network stack at some
> point it should probably be using dev_alloc_skb().  this patches fixes
> a crash during pppoatm operation when an unchecked skb_push() operates on
> a buffer returned by the nicstar.
> 
> please apply to 2.6 and 2.4 kernels (and if at all possible could
> i get this in the soon to be released 2.4.26 kernel?)

Good catch, applied.

I'll do my best to get Marcelo to eats this soon, but no promises.
:-)

<Prev in Thread] Current Thread [Next in Thread>