netdev
[Top] [All Lists]

Re: [PATCH] Force IPv6 FIB gc on device shutdown

To: Andi Kleen <ak@xxxxxxx>
Subject: Re: [PATCH] Force IPv6 FIB gc on device shutdown
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Fri, 9 Apr 2004 15:31:17 -0700
Cc: netdev@xxxxxxxxxxx, tspat@xxxxxxxxxx, shemminger@xxxxxxxx
In-reply-to: <20040409173901.62ebf75b.ak@suse.de>
References: <20040409173901.62ebf75b.ak@suse.de>
Sender: netdev-bounce@xxxxxxxxxxx
Thanks Andi.

A week ago Thomas Spatzier posted a similar patch, and I had
asked Stephen Hemminger (in private email) for his take on
this.

So here is the final patch I applied, based upon your and
Thomas's patches, plus Stephen's commentary.  (hint: NETDEV_DOWN
is sufficient, because unregister causes a NETDEV_DOWN event
if necessary).

Thanks everyone.

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/04/09 15:29:23-07:00 davem@xxxxxxxxxxxxxxxxxx 
#   [IPV6]: In ndisc_netdev_event, handle NETDEV_DOWN.
#   
#   Based upon patches and commentary from Thomas Spatzier,
#   Stephen Hemminger, and Andi Kleen.
# 
# net/ipv6/ndisc.c
#   2004/04/09 15:29:00-07:00 davem@xxxxxxxxxxxxxxxxxx +4 -0
#   [IPV6]: In ndisc_netdev_event, handle NETDEV_DOWN.
#   
#   Based upon patches and commentary from Thomas Spatzier,
#   Stephen Hemminger, and Andi Kleen.
# 
diff -Nru a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
--- a/net/ipv6/ndisc.c  Fri Apr  9 15:30:59 2004
+++ b/net/ipv6/ndisc.c  Fri Apr  9 15:30:59 2004
@@ -1403,6 +1403,10 @@
                neigh_changeaddr(&nd_tbl, dev);
                fib6_run_gc(0);
                break;
+       case NETDEV_DOWN:
+               neigh_ifdown(&nd_tbl, dev);
+               fib6_run_gc(0);
+               break;
        default:
                break;
        }

<Prev in Thread] Current Thread [Next in Thread>