| To: | Paul Fulghum <paulkf@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [janitor] use netdev_priv() in synclink (char. driver) |
| From: | "Randy.Dunlap" <rddunlap@xxxxxxxx> |
| Date: | Sat, 6 Mar 2004 20:16:40 -0800 |
| Cc: | netdev@xxxxxxxxxxx, jgarzik@xxxxxxxxx |
| In-reply-to: | <1078499709.2076.5.camel@deimos.microgate.com> |
| Organization: | OSDL |
| References: | <20040303142907.09d0f7bd.rddunlap@osdl.org> <20040303150105.7ff770b0.rddunlap@osdl.org> <1078499709.2076.5.camel@deimos.microgate.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On 05 Mar 2004 09:15:09 -0600 Paul Fulghum <paulkf@xxxxxxxxxxxxx> wrote: | On Wed, 2004-03-03 at 17:01, Randy.Dunlap wrote: | > | | > | From: Carlo Perassi <carlo@xxxxxxxx> | > | and Randy.Dunlap <rddunlap@xxxxxxxx> | > | > | > Jeff, can you add this patch and the fusion/mptlan driver | > patch as well? | > | > -- | > ~Randy | > | > | > [snip] | > _ | | | This patch breaks the driver. | | The pointer stored in dev->priv points to a structure that is | allocated and maintained by the driver. | | Changing from dev->priv to netdev_priv(dev) returns a pointer | to memory at the end of the net_device structure. | | These are two different things. | | So with the patch, the driver gets a pointer to something | other than the device private information that it needs. | | Please dont apply this patch. Yes, I see. I appreciate you reviewing and catching that, Paul. Thanks, -- ~Randy |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Issue Report: forcedeth v0.23, irq with unknown events, Adam . Torgerson |
|---|---|
| Next by Date: | Re: Issue Report: forcedeth v0.23, irq with unknown events, Carl-Daniel Hailfinger |
| Previous by Thread: | Re: [janitor] use netdev_priv() in synclink (char. driver), Paul Fulghum |
| Next by Thread: | Re: [janitor] use netdev_priv() in fusion/mptlan, Randy.Dunlap |
| Indexes: | [Date] [Thread] [Top] [All Lists] |