netdev
[Top] [All Lists]

Re: [PATCH 2.4.26-pre1] Allow ebtables module to change protocol in neti

To: "Simon Barber" <simon@xxxxxxxxxxxxxx>
Subject: Re: [PATCH 2.4.26-pre1] Allow ebtables module to change protocol in netif_receive_skb
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 26 Feb 2004 11:57:09 -0800
Cc: linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, bdschuym@xxxxxxxxxx
In-reply-to: <AC8C1F46CD753F4AAC8F890E35A9EB461C670B@webmail.instant802.com>
References: <AC8C1F46CD753F4AAC8F890E35A9EB461C670B@webmail.instant802.com>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 25 Feb 2004 14:47:41 -0800
"Simon Barber" <simon@xxxxxxxxxxxxxx> wrote:

> Currently skb->protocol is read before the bridge is called, even though
> it's not used until after. Hence if an ebtables module changes the
> protocol of a frame the wrong protocol is interpreted.

Applied, even though ebtables is not in 2.4.x yet the change is valid.
I've applied your 2.6.x variant too of course.

Thanks Simon.

<Prev in Thread] Current Thread [Next in Thread>