netdev
[Top] [All Lists]

ip multicast bug

To: netdev@xxxxxxxxxxx
Subject: ip multicast bug
From: Karlis Peisenieks <karlis@xxxxx>
Date: Tue, 17 Feb 2004 17:55:16 +0200
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.3i
Hello,

Patch below fixes kernel crash when multicast group is joined on 
disabled interface with IP address added.

The problem is 
ip_mc_join_group->ip_mc_inc_group->igmp_group_added
->igmp_ifc_event->igmp_ifc_start_timer which does mod_timer on 
uninitialized timer_struct (mr_ifc_timer). As soon as timer fires, 
kernel crashes.

Multicast related fields of in_device are only initialized in ip_mc_up
which gets called when device is enabled.

Perhaps somebody with more clue on multicast implementation can comment 
on this fix - is this fix enough or maybe wrong.


Karlis

Attachment: igmp.c.patch
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>