Re: 2.6: QoS scheduling not working with IP-over-IP

["David S. Miller" <davem@xxxxxxxxxx>]

On 12 Feb 2004 00:43:59 -0500
jamal <hadi@xxxxxxxxxx> wrote:

> On Thu, 2004-02-12 at 00:25, jamal wrote:
> 
> > > OK, however, old behavior would be like setting tx_queue_len to '1'.
> > > Do we wish to preserve this?
> 
> I think i misunderstood you - you are saying maybe it was not a bug
> after all in pfifo, right? i.e the off by one is ok.

No, you understood me the first time.

I am saying, the PFIFO fix was correct.  And therefore if we are to preserve
the tunnel device behavior precisely to what happened before the PFIFO fix
we must set the tx_queue_len to '1'.

What use is any other value?  Show me a code path where more than one packet
can occupy the queue of one of these tunnel devices? :-)

Packets get headers added and straight to transmit to next device.
->hard_start_xmit() routines of these drivers always consume SKB and
return 0.