netdev
[Top] [All Lists]

Re: [PATCH][RFC] use completions instead of sleep_on for rpciod

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH][RFC] use completions instead of sleep_on for rpciod
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Sun, 8 Feb 2004 12:43:26 -0800
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20040207144405.GA19416@lst.de>
References: <20040207144405.GA19416@lst.de>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 7 Feb 2004 15:44:05 +0100
Christoph Hellwig <hch@xxxxxx> wrote:

> The rpciod shutdown code gives ugly sleep_on without BKL warnings in
> -mm.  And it looks indeed somewhat racy.
> 
> The easy fix would be to simply use a completion as in the patch below,
> but that removes all the signal fuzzing semantics the current code has.
> I don't really understand why we want to cancel the operation by
> signals, but I think it'd be better to leave that to people familar with
> the code anyway..

I think your patch is fine, and there are no signal issues (such code looks
merely to be some abberation rather than anything else).

So I've added it to my tree.

<Prev in Thread] Current Thread [Next in Thread>