netdev
[Top] [All Lists]

Re: [PATCH][IPV6][NDISC] unify ipv6 output routine

To: Mika Penttilä <mika.penttila@xxxxxxxxxxx>
Subject: Re: [PATCH][IPV6][NDISC] unify ipv6 output routine
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Fri, 6 Feb 2004 19:48:44 -0800
Cc: kazunori@xxxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, usagi-core@xxxxxxxxxxxxxx
In-reply-to: <4023D6FB.9010909@kolumbus.fi>
References: <200402070232.33771.kazunori@miyazawa.org> <4023D6FB.9010909@kolumbus.fi>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 06 Feb 2004 20:03:39 +0200
Mika Penttilä <mika.penttila@xxxxxxxxxxx> wrote:

> >Yoshifuji-san and I send the patch which unifies IPv6 output routine and 
> >remove
> >RTF_NDISC again. It resolves an issue of IPv6 IPsec with neighbor discovery
> >without a flag.
> 
> You break multicast replies, see what ndisc_build_ll_hdr() does...

That's right, and compiler should have warned about ndisc_build_ll_hdr()
(a static function in ndisc.c) since it was no longer referenced after
applying the patch, which would be a clue that something was wrong :-)


<Prev in Thread] Current Thread [Next in Thread>