netdev
[Top] [All Lists]

Re: Fw: [Kernel-janitors] net/atm/clip.c: check kmem_cache_create() #1

To: Francois Romieu <romieu@xxxxxxxxxxxxx>
Subject: Re: Fw: [Kernel-janitors] net/atm/clip.c: check kmem_cache_create() #1
From: chas williams (contractor) <chas@xxxxxxxxxxxxxxxx>
Date: Thu, 05 Feb 2004 13:48:55 -0500
Cc: netdev@xxxxxxxxxxx
In-reply-to: Message from Francois Romieu <romieu@fr.zoreil.com> of "Thu, 05 Feb 2004 19:38:13 +0100." <20040205193813.A4230@electric-eye.fr.zoreil.com>
Sender: netdev-bounce@xxxxxxxxxxx
In message <20040205193813.A4230@xxxxxxxxxxxxxxxxxxxxxxxxxx>,Francois Romieu wr
ites:
>As long as the ugly-ifdef patrol does not bite, it's fine with me. :o)

it would less ugly if people could accept a possibly unused stack
variable for the !CONFIG_PROC_FS case.

>It would not hurt. Do you have a specific race in mind before I send
>an update on top your patch for the clip_tbl_hook -> clip_tbl change ?

no particular race.  just that the arp /proc entry should not be available
until clip gets initialized.  clip_tbl_hook should only be used by 
net/ipv4/arp.c really.

<Prev in Thread] Current Thread [Next in Thread>