Re: [PATCH] fix netfilter refcounting [was Re: Conntrack leak (2.6.2rc2)]

["David S. Miller" <davem@xxxxxxxxxx>]

On Tue, 3 Feb 2004 18:43:38 +0100 (CET)
Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx> wrote:

> Steve Hill reported a conntrack leakage in 2.6.2-rc2 when nat is enabled
> and the system forwards fragmented packets. It turned out that an
> nf_conntrack_put was missing from ip_copy_metadata:

Yeah, but... look at what you patched.

>       /* Connection association is same as pre-frag packet */
> +     nf_conntrack_put(to->nfct);
>       to->nfct = from->nfct;
>       nf_conntrack_get(to->nfct);

What about that comment?