| To: | schwidefsky@xxxxxxxxxx |
|---|---|
| Subject: | Patchlet 2.6 iucv |
| From: | Pete Zaitcev <zaitcev@xxxxxxxxxx> |
| Date: | Mon, 2 Feb 2004 20:12:03 -0800 |
| Cc: | netdev@xxxxxxxxxxx |
| Organization: | Red Hat, Inc. |
| Sender: | netdev-bounce@xxxxxxxxxxx |
Hi, Martin,
it seems that someone misused container_of. Spotted by Al Viro.
Please pass to whoever is responsible for IUCV.
-- Pete
--- linux-2.6.1/drivers/s390/net/netiucv.c 2003-10-01 15:17:54.000000000
-0700
+++ linux-2.6.1-s390/drivers/s390/net/netiucv.c 2004-02-02 19:59:11.000000000
-0800
@@ -1258,8 +1258,7 @@
buffer_write (struct device *dev, const char *buf, size_t count)
{
struct netiucv_priv *priv = dev->driver_data;
- struct net_device *ndev =
- container_of((void *)priv, struct net_device, priv);
+ struct net_device *ndev = priv->conn->netdev;
char *e;
int bs1;
char tmp[CTRL_BUFSIZE];
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Deadlock problem with dev->refcnt somewhere in netlink/multicast... [PATCH], David S. Miller |
|---|---|
| Next by Date: | Re: Deadlock problem with dev->refcnt somewhere in netlink/multicast... [PATCH], Willy Tarreau |
| Previous by Thread: | Re: Deadlock problem with dev->refcnt somewhere in netlink/multicast... [PATCH], David Stevens |
| Next by Thread: | [PATCH] IPV6: fix a possible dst leakage in ndisc_send_redirect(), YOSHIFUJI Hideaki / 吉藤英明 |
| Indexes: | [Date] [Thread] [Top] [All Lists] |