| To: | Andi Kleen <ak@xxxxxxx> |
|---|---|
| Subject: | Re: Submission for S2io 10GbE driver |
| From: | Stephen Hemminger <shemminger@xxxxxxxx> |
| Date: | Fri, 23 Jan 2004 16:21:34 -0800 |
| Cc: | "Leonid Grossman" <leonid.grossman@xxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <20040123232209.2739e6aa.ak@suse.de> |
| Organization: | Open Source Development Lab |
| References: | <002201c3e1f6$f97896e0$5d50ff11@S2IOtech.com> <20040123232209.2739e6aa.ak@suse.de> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
Noticed the setup loopback test seems to register for a packet type and then forget to unregister that type! Also nothing really restricts the packet type to only coming in on the expected interface; therefore if someone sends the same packet in over another interface, then sp->loop_pkt_cnt will end up incrementing some other drivers private data structure *bad*. IMHO the whole loopback test frame stuff seems like something in a test bed driver, not production code. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: r8169 patch set, Francois Romieu |
|---|---|
| Next by Date: | Re: FW: Submission for S2io 10GbE driver, Francois Romieu |
| Previous by Thread: | Re: FW: Submission for S2io 10GbE driver, Andi Kleen |
| Next by Thread: | RE: Submission for S2io 10GbE driver, Leonid Grossman |
| Indexes: | [Date] [Thread] [Top] [All Lists] |