Re: [PATCH] Uninitialized dst in ip6_dst_lookup

["David S. Miller" <davem@xxxxxxxxxx>]

On Tue, 20 Jan 2004 11:46:02 -0800 (PST)
Krishna Kumar <krkumar@xxxxxxxxxx> wrote:

> ip6_dst_lookup() is supposed to fill in the *dst, hence it must not
> dereference *dst until it allocates it. However if the passed sk is
> NULL and *dst is not set by the caller, the following code will
> dereference uninitialized memory :
> 
>       if (*dst == NULL)
>               *dst = ip6_route_output(sk, fl); >>>>> will not execute
>       if ((err = (*dst)->error))  >>>>> dereference bad stack address.
>               goto out_err_release;
> 
> I am suggesting moving the responsibility of ensuring a good *dst from the
> callers to ip6_dst_lookup().

I agree, patch applied.

Thanks.