netdev
[Top] [All Lists]

Re: [PATCH] more improvement to dev_alloc_name -- strnchr

To: Andi Kleen <ak@xxxxxxx>
Subject: Re: [PATCH] more improvement to dev_alloc_name -- strnchr
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Mon, 19 Jan 2004 13:07:44 -0800
Cc: davem@xxxxxxxxxx, ap@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040119210605.3cea32b0.ak@suse.de>
Organization: Open Source Development Lab
References: <1074302619.40088e9bd44a6@www.geekmail.cc> <20040119113204.5913a8d6.shemminger@osdl.org> <20040119210605.3cea32b0.ak@suse.de>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 19 Jan 2004 21:06:05 +0100
Andi Kleen <ak@xxxxxxx> wrote:

> On Mon, 19 Jan 2004 11:32:04 -0800
> Stephen Hemminger <shemminger@xxxxxxxx> wrote:
> 
> > +#ifndef __HAVE_ARCH_STRNCHR
> 
> Please drop the ifdef. Don't want to encourage anybody to write
> strrchr() in assembly.
> 
> -Andi

I assume you mean strnchr not strrchr. Mainly just following the style
of all the other string routines.
What if gcc does it inline in some future version?

<Prev in Thread] Current Thread [Next in Thread>