netdev
[Top] [All Lists]

Re: [PATCH] (1/5) replay netdev notifier events on registration

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH] (1/5) replay netdev notifier events on registration
From: chas williams (contractor) <chas@xxxxxxxxxxxxxxxx>
Date: Thu, 15 Jan 2004 22:19:29 -0500
Cc: Stephen Hemminger <shemminger@xxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: Your message of "Thu, 15 Jan 2004 00:42:55 PST." <20040115004255.62dc8b95.davem@redhat.com>
Reply-to: chas3@xxxxxxxxxxxxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
In message <20040115004255.62dc8b95.davem@xxxxxxxxxx>,"David S. Miller" writes:
>2) Add a type cookie or similar to the generic netdev, only devices
>   which need to identify themselves in these generic kind of cases
>   add identifier values there, so currently that would be MPOA and
>   QETH, then the code goes:
>
>       if (dev->type_cookie == NETDEV_TYPE_MPOA)
>               return NOTIFY_DONE;

while just as ugly it would probably suffice to check dev->start_xmit()
to make sure its the routine you know it should be.  since the number 
of drivers that need to do this seems small this might be simpler.

<Prev in Thread] Current Thread [Next in Thread>