netdev
[Top] [All Lists]

Re: [PATCH 4/5] xfrm_state_construct doesn't set tunnel state

To: Krishna Kumar <krkumar@xxxxxxxxxx>
Subject: Re: [PATCH 4/5] xfrm_state_construct doesn't set tunnel state
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Tue, 13 Jan 2004 23:25:24 -0800
Cc: netdev@xxxxxxxxxxx, krkumar@xxxxxxxxxx
In-reply-to: <Pine.LNX.4.44.0401131323410.25742-100000@linux-udp14999547uds>
References: <Pine.LNX.4.44.0401131319510.25742-100000@linux-udp14999547uds> <Pine.LNX.4.44.0401131323410.25742-100000@linux-udp14999547uds>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 13 Jan 2004 13:24:23 -0800 (PST)
Krishna Kumar <krkumar@xxxxxxxxxx> wrote:

> xfrm_state_construct doesn't set x->km.state to XFRM_STATE_DEAD. This can lead
> to the BUG_TRAP in __xfrm_state_destroy when xfrm_state_put() finds this is
> the last reference. This was reported as one of the symptoms of [Bug 1754]
> some time back.

Smells just like the nearly identical case in ipcomp :-)

Patch applied, thanks.

<Prev in Thread] Current Thread [Next in Thread>