| To: | "David S. Miller" <davem@xxxxxxxxxx> |
|---|---|
| Subject: | [PATCH] bridge use read_lock when scanning device list |
| From: | Stephen Hemminger <shemminger@xxxxxxxx> |
| Date: | Mon, 12 Jan 2004 13:46:45 -0800 |
| Cc: | bridge@xxxxxxxx, netdev@xxxxxxxxxxx |
| Organization: | Open Source Development Lab |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On 2.6.1, bridge is using rtnl_shlock which is equivalent to rtnl_lock when
all it really needs to do is read_lock(&dev_base_lock).
diff -Nru a/net/bridge/br_if.c b/net/bridge/br_if.c
--- a/net/bridge/br_if.c Mon Jan 12 13:45:44 2004
+++ b/net/bridge/br_if.c Mon Jan 12 13:45:44 2004
@@ -252,12 +252,12 @@
struct net_device *dev;
int i = 0;
- rtnl_shlock();
+ read_lock(&dev_base_lock);
for (dev = dev_base; dev && i < num; dev = dev->next) {
if (dev->priv_flags & IFF_EBRIDGE)
indices[i++] = dev->ifindex;
}
- rtnl_shunlock();
+ read_unlock(&dev_base_lock);
return i;
}
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [2.4] e1000 leaking pci mappings on rx errors?, Olof Johansson |
|---|---|
| Next by Date: | [PATCH] convert /proc/net/dev_mcast to seq_file, Stephen Hemminger |
| Previous by Thread: | Security bug in 2.2 kernel series, Tomasz Grabowski |
| Next by Thread: | Re: [PATCH] bridge use read_lock when scanning device list, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |