netdev
[Top] [All Lists]

Re: [PATCH]: Remove backlog accounting from TBF, pass limit to the defau

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: [PATCH]: Remove backlog accounting from TBF, pass limit to the default inner bfifo qdisc only
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Wed, 24 Dec 2003 19:22:34 -0800
Cc: netdev@xxxxxxxxxxx
In-reply-to: <3FE98BE9.2000708@trash.net>
References: <3FE98BE9.2000708@trash.net>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 24 Dec 2003 13:51:53 +0100
Patrick McHardy <kaber@xxxxxxxxx> wrote:

> when TBF was made classful, backlog accounting was kept inside
> TBF for reasons I don't understand. When used with SFQ as inner
> qdisc, TBF can not know the exact backlog once SFQ returned
> NET_CMIT_CN. An underestimate leads to backlog becoming negative
> when the queue drains, it stops accepting packets then.
 ...
> This patch removes backlog accounting from TBF, the limit
> parameter is just passed to the default inner bfifo, once it
> is replaced limit is not effective anymore.

Applied to both 2.4.x and 2.6.x, thanks Patrick.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH]: Remove backlog accounting from TBF, pass limit to the default inner bfifo qdisc only, David S. Miller <=