| To: | Shirley Ma <mashirle@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH]snmp6 64-bit counter support in proc.c |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Fri, 5 Dec 2003 12:31:33 -0800 |
| Cc: | kuznet@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, xma@xxxxxxxxxx |
| In-reply-to: | <200312051214.48076.mashirle@us.ibm.com> |
| References: | <200312021240.PAA01536@yakov.inr.ac.ru> <200312051214.48076.mashirle@us.ibm.com> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Fri, 5 Dec 2003 12:14:47 -0800 Shirley Ma <mashirle@xxxxxxxxxx> wrote: > I add this because there are some 64-bit counters in the new IPv6 MIBs. > This patch has been tested agaist linux-2.6.0-test9, and cleanly applied to > linux-2.6.0-test11. "sizeof(unsigned long)" evaluates to 8 on 64-bit systems, yet you assume it always evaluated to 4 as on 32-bit systems. Maybe it would be wiser to explicitly use 'u32' and 'u64' for the types of the snmp counters? This has always been a sore area. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH]snmp6 64-bit counter support in proc.c, Shirley Ma |
|---|---|
| Next by Date: | Re: [ROUTE] PMTU only works on half the time, David S. Miller |
| Previous by Thread: | [PATCH]snmp6 64-bit counter support in proc.c, Shirley Ma |
| Next by Thread: | Re: IPv6 MIB:ipv6PrefixTable implementation, Shirley Ma |
| Indexes: | [Date] [Thread] [Top] [All Lists] |