netdev
[Top] [All Lists]

Re: [ROUTE] PMTU only works on half the time

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [ROUTE] PMTU only works on half the time
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Mon, 1 Dec 2003 13:51:54 -0800
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20031201204700.GA20349@gondor.apana.org.au>
References: <20031201201651.GA20194@gondor.apana.org.au> <20031201204700.GA20349@gondor.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 2 Dec 2003 07:47:00 +1100
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> On Tue, Dec 02, 2003 at 07:16:51AM +1100, herbert wrote:
> > 
> > I found out that PMTU only works on those routing cache entries where
> > rt_src != 0.  This patch should make it work for all matching entries.
> 
> That patch removed one line too many.  This one should be better.

Hmmm... 

Herbert, do you see how the outer loop and the skey[] thing works in
this PMTU handling code?  This takes care of comparing both iph->saddr
and '0' against rt->rt_src.

<Prev in Thread] Current Thread [Next in Thread>