| To: | torvalds@xxxxxxxx |
|---|---|
| Subject: | [BK PATCH] fix oopsable net driver bug |
| From: | Jeff Garzik <jgarzik@xxxxxxxxx> |
| Date: | Sun, 23 Nov 2003 12:36:11 -0500 |
| Cc: | netdev@xxxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.3.28i |
dev_kfree_skb, unlike kfree, will oops if passed NULL...
and it might be passed NULL in this case, if skb_padto() returns NULL.
Linus, please do a
bk pull bk://gkernel.bkbits.net/net-drivers-2.5
This will update the following files:
drivers/net/sis190.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
through these ChangeSets:
<jgarzik@xxxxxxxxxx> (03/11/20 1.1478)
[netdrvr sis190] fix oopsable bug in TX path, related to skb_padto return
Caught by Francois Romieu.
diff -Nru a/drivers/net/sis190.c b/drivers/net/sis190.c
--- a/drivers/net/sis190.c Sun Nov 23 12:34:07 2003
+++ b/drivers/net/sis190.c Sun Nov 23 12:34:07 2003
@@ -949,7 +949,8 @@
drop_tx:
tp->stats.tx_dropped++;
- dev_kfree_skb(skb);
+ if (skb)
+ dev_kfree_skb(skb);
return 0;
}
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [ANNOUNCE] Porting MPLS-Linux to 2.6 (2.6.0-test9-bk22) comments welcome., James R. Leu |
|---|---|
| Next by Date: | Re: Kernel crash in 2.6.0-test9-mm3, Rask Ingemann Lambertsen |
| Previous by Thread: | IPv6 multicast (MLD,IGMP) code bypasses netfilter hooks, Harald Welte |
| Next by Thread: | [PATCH] e100: Enable receiving bogus packets, and transmitting bad/custom CRC, Ben Greear |
| Indexes: | [Date] [Thread] [Top] [All Lists] |