netdev
[Top] [All Lists]

Re: [IPV4] Always set hoplimit

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [IPV4] Always set hoplimit
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Tue, 18 Nov 2003 16:59:09 -0800
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20031113110438.GA29522@gondor.apana.org.au>
References: <20031113110438.GA29522@gondor.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 13 Nov 2003 22:04:38 +1100
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> Is there any reason why local/broadcast packets should have a ttl of zero?
> This is the result of the HOPLIMIT change as those packets doesn't get
> their HOPLIMIT set.  This patch sets it for them.
> 
> Am I missing something?

I don't believe I changed this behavior intentionally.  Let me
look into the revision history to verify that.  I'm likely going
to apply your fix tonight, thanks.

Although it is an interesting question because both broadcasts and
locally destined packets have no reason to make it past the local
subnet and thus have their TTL/HOPLIMIT decremented or tested.  I
therefore cannot imagine a case where the current behavior would cause
a problem.

Did you run into an actual problem that led you to this issue?  If
so, what was it?  Or was this just determined by pure code review?

<Prev in Thread] Current Thread [Next in Thread>