Re: [PATCH] ref count bug in MLDv2

["David S. Miller" <davem@xxxxxxxxxx>]

On Wed, 12 Nov 2003 16:56:20 -0800 (PST)
Krishna Kumar <krkumar@xxxxxxxxxx> wrote:

> Dave Stevens and I  found this problem when the device is going down,
> mc_destroy_dev() calls igmp6_group_dropped which checks for IFF_UP before
> calling mld_add_delrec and posting a timer.
> 
> IFF_UP need not be set though the device is going down (eg last address
> deletion). So timer can get started at this time. The problem is that
> when the timer fires (after ifdown is over) for the last time
> (mld_ifc_timer_expire), it does a __in6_dev_put() and that will not free
> up the idev.
> 
> To fix that that the check must be for idev->dead instead.

Applied, thanks a lot Krishna.