Re: [PATCH] ethertap can use alloc_etherdev

[Stephen Hemminger <shemminger@xxxxxxxx>]

On Tue, 11 Nov 2003 18:52:48 -0500
Jeff Garzik <jgarzik@xxxxxxxxx> wrote:

> Stephen Hemminger wrote:
> > Can use alloc_etherdev, don't need to call ether_setup.
> > Found by viro.
> > 
> > diff -Nru a/drivers/net/ethertap.c b/drivers/net/ethertap.c
> > --- a/drivers/net/ethertap.c        Tue Nov 11 09:36:15 2003
> > +++ b/drivers/net/ethertap.c        Tue Nov 11 09:36:15 2003
> > @@ -72,8 +72,7 @@
> >     struct net_device *dev;
> >     int err = -ENOMEM;
> >  
> > -   dev = alloc_netdev(sizeof(struct net_local), "tap%d",
> > -                      ether_setup);
> > +   dev = alloc_etherdev(sizeof(struct net_local));
> 
> 
> Um?  This clearly changes the device's interface name, which 
> alloc_etherdev() not ether_setup() assigns.
> 

It forces it already several lines later and it hasn't registered yet.

        if (!dev)
                goto out;

        SET_MODULE_OWNER(dev);

        sprintf(dev->name, "tap%d", unit);
        dev->base_addr = unit + NETLINK_TAPBASE;


-- 
Stephen Hemminger <shemminger@xxxxxxxx>
Open Source Development Lab      http://developer.osdl.org

:-) Ignorance never settles a question