Re: net/packet/af_packet.c:{1057,1073}: flags vs. msg->flags

netdev

Re: net/packet/af_packet.c:{1057,1073}: flags vs. msg->flags

To:	"Ihar 'Philips' Filipau" <filia@xxxxxxxxxxxx>
Subject:	Re: net/packet/af_packet.c:{1057,1073}: flags vs. msg->flags
From:	"David S. Miller" <davem@xxxxxxxxxx>
Date:	Mon, 10 Nov 2003 23:12:38 -0800
Cc:	linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to:	<3FAF7236.7020209@softhome.net>
References:	<3FAF7236.7020209@softhome.net>
Sender:	netdev-bounce@xxxxxxxxxxx

On Mon, 10 Nov 2003 12:10:46 +0100
"Ihar 'Philips' Filipau" <filia@xxxxxxxxxxxx> wrote:

>     On line 1057 we have: "msg->msg_flags|=MSG_TRUNC;" to indicate that 
> message was truncated.
> 
>     But on line 1073, where we make return status to user, we check 
> against user suplied flags, but NOT msg->msg_flags.
> 
>     It looks like obvious typo.

Indeed, you're right.

Thanks for the report, I'll fix this in both 2.4.x and 2.6.x

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
net/packet/af_packet.c:{1057,1073}: flags vs. msg->flags, Ihar 'Philips' Filipau Re: net/packet/af_packet.c:{1057,1073}: flags vs. msg->flags, David S. Miller <=

Previous by Date:	Re: [PATCH] IPV{4,6}: Normalize jiffies reported to userspace in routing code (missing pieces), David S. Miller
Next by Date:	[2.6 PATCH] ipvs - make sure the timer expires on one cpu, Julian Anastasov
Previous by Thread:	net/packet/af_packet.c:{1057,1073}: flags vs. msg->flags, Ihar 'Philips' Filipau
Next by Thread:	[PATCH] NET: Normalize jiffies reported to userspace, in neighbor management code, YOSHIFUJI Hideaki / 吉藤英明
Indexes:	[Date] [Thread] [Top] [All Lists]