netdev
[Top] [All Lists]

Re: [PATCH] enabling netdev boot options (2.6.0-t9)

To: "Randy.Dunlap" <rddunlap@xxxxxxxx>
Subject: Re: [PATCH] enabling netdev boot options (2.6.0-t9)
From: Rask Ingemann Lambertsen <rask@xxxxxxxxxx>
Date: Sun, 9 Nov 2003 11:55:35 +0100
Cc: netdev@xxxxxxxxxxx, saw@xxxxxxxxxxxxx, akpm@xxxxxxxx
In-reply-to: <20031108204406.5dbbdc87.rddunlap@osdl.org>; from rddunlap@osdl.org on Sat, Nov 08, 2003 at 08:44:06PM -0800
References: <20031108160441.3a0a5505.rddunlap@osdl.org> <20031108204406.5dbbdc87.rddunlap@osdl.org>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.2.5.1i
On Sat, Nov 08, 2003 at 08:44:06PM -0800, Randy.Dunlap wrote:
> 
> Here's an update for 2.6.0-test9.  This update adds
> dev_alloc_name_lock(), which takes and releases the rtnl lock
> to call dev_alloc_name(), so that the caller doesn't have to do that.
> 
> More comments?

I don't like that name for the function. dev_alloc_name_lock() makes it
natural to think that there is a matching dev_alloc_name_unlock() function
which you should call afterwards. How about dev_alloc_name_locked() or
dev_alloc_name_with_lock() instead?

-- 
Regards,
Rask Ingemann Lambertsen

<Prev in Thread] Current Thread [Next in Thread>