netdev
[Top] [All Lists]

Re: FW: [PATCH] - Incorrect cpumask definition in net/core/flow.c

To: Jack Steiner <steiner@xxxxxxx>
Subject: Re: FW: [PATCH] - Incorrect cpumask definition in net/core/flow.c
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Fri, 7 Nov 2003 16:12:12 -0800
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20031107223729.GA20687@sgi.com>
References: <20031107223729.GA20687@sgi.com>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 7 Nov 2003 16:37:29 -0600
Jack Steiner <steiner@xxxxxxx> wrote:

> The field "cpumap" is defined as a "unsigned long". It 
> should be a "cpumask_t".

You can't just do this, that's more broken than the original
code.

You have to _ALSO_ change all of the accesses to these objects
to use the cpumask interfaces.

<Prev in Thread] Current Thread [Next in Thread>