netdev
[Top] [All Lists]

Re: [2.6.0-test8/9] ethertap oops

To: Andi Kleen <ak@xxxxxx>
Subject: Re: [2.6.0-test8/9] ethertap oops
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Sun, 26 Oct 2003 23:48:28 -0800
Cc: simon.roscic@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <m3ekwz7h3z.fsf@averell.firstfloor.org>
References: <L1fo.3gb.9@gated-at.bofh.it> <m3ekwz7h3z.fsf@averell.firstfloor.org>
Sender: netdev-bounce@xxxxxxxxxxx
On Sun, 26 Oct 2003 23:45:52 +0100
Andi Kleen <ak@xxxxxx> wrote:

> diff -u linux-2.6.0test7mm1-averell/drivers/net/ethertap.c-o 
> linux-2.6.0test7mm1-averell/drivers/net/ethertap.c
> --- linux-2.6.0test7mm1-averell/drivers/net/ethertap.c-o      2003-09-11 
> 04:12:33.000000000 +0200
> +++ linux-2.6.0test7mm1-averell/drivers/net/ethertap.c        2003-10-26 
> 23:41:17.000000000 +0100

This part looks good, applied.

> diff -u linux-2.6.0test7mm1-averell/net/netlink/af_netlink.c-o 
> linux-2.6.0test7mm1-averell/net/netlink/af_netlink.c
> --- linux-2.6.0test7mm1-averell/net/netlink/af_netlink.c-o    2003-10-09 
> 00:29:02.000000000 +0200
> +++ linux-2.6.0test7mm1-averell/net/netlink/af_netlink.c      2003-10-26 
> 23:42:44.000000000 +0100
> @@ -777,6 +777,7 @@
>       if (input)
>               nlk_sk(sk)->data_ready = input;
>  
> +     sk->sk_protocol = unit;
>       netlink_insert(sk, 0);
>       return sk;
>  }

This part is not needed, netlink_create() does this for us :-)

Thanks Andi.

<Prev in Thread] Current Thread [Next in Thread>