| To: | Andrew Morton <akpm@xxxxxxxx> |
|---|---|
| Subject: | Re: [Bugme-new] [Bug 1360] New: Can't access /proc/self/fd/0 from sshd when no pty allocated. |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Sat, 18 Oct 2003 23:57:35 -0700 |
| Cc: | dtucker@xxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20031018172736.417bf89d.akpm@osdl.org> |
| References: | <200310151142.h9FBgi5k029003@fire-1.osdl.org> <20031018172736.417bf89d.akpm@osdl.org> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Sat, 18 Oct 2003 17:27:36 -0700
Andrew Morton <akpm@xxxxxxxx> wrote:
> This appears to be deliberate:
>
> /*
> * In theory you can't get an open on this inode, but /proc provides
> * a back door. Remember to keep it shut otherwise you'll let the
> * creepy crawlies in.
> */
>
> static int sock_no_open(struct inode *irrelevant, struct file *dontcare)
> {
> return -ENXIO;
> }
>
> I do not know why; the comment is fairly useless.
For many socket types there are no sane open() semantics.
If I open() a unconnected socket, what does that mean?
Should it connect, of do something like a dup()?
This code has been this way for a long time, anyone who wants to
change this needs to deal with and address all the aforementioned
issues.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | register_netdevice return val fix, Andrew Morton |
|---|---|
| Next by Date: | Re: [Bugme-new] [Bug 1371] New: kernel fails to compile with ipv6 error, David S. Miller |
| Previous by Thread: | Re: [Bugme-new] [Bug 1360] New: Can't access /proc/self/fd/0 from sshd when no pty allocated., Andrew Morton |
| Next by Thread: | Re: [Bugme-new] [Bug 1360] New: Can't access /proc/self/fd/0 from sshd when no pty allocated., Darren Tucker |
| Indexes: | [Date] [Thread] [Top] [All Lists] |