netdev
[Top] [All Lists]

Re: [PATCH?] Fix sniffing of ARP replies

To: "Petr Vandrovec" <VANDROVE@xxxxxxxxxx>
Subject: Re: [PATCH?] Fix sniffing of ARP replies
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 16 Oct 2003 15:21:36 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <32A9D366A0B@vcnet.vc.cvut.cz>
References: <32A9D366A0B@vcnet.vc.cvut.cz>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 16 Oct 2003 12:07:23 +0200
"Petr Vandrovec" <VANDROVE@xxxxxxxxxx> wrote:

> It behaves same way it behaved. But recently you renamed packet_type.data
> to packet_type.af_packet_priv, saying that af_packet_priv should be used
> only by AF_PACKET code, by nobody else. So I trusted you, removed
> packet_type.data (and packet_type.af_packet_priv) references from the
> code - and things stopped working, as with af_packet_priv==NULL ARP
> replies are not delivered to the registered packet_type callback, as
> these packets match skb->sk == pt->af_packet_priv for af_packet_priv == NULL.

vmware was trying to influence the behavior of input packet
delivery by setting ->data in a way which was never defined.
That facility existed and continues to exist for the sake
of AF_PACKET solely, what vmware was doing just happened to work.

<Prev in Thread] Current Thread [Next in Thread>