netdev
[Top] [All Lists]

Re: [PATCH] (5/6) ibmtr -- probe2

To: Mike_Phillips@xxxxxxxxxxx
Subject: Re: [PATCH] (5/6) ibmtr -- probe2
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Thu, 16 Oct 2003 13:08:58 -0700
Cc: jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx, netdev-bounce@xxxxxxxxxxx
In-reply-to: <OFF934C8CA.6C5807E0-ON88256DC1.007CA7CB-88256DC1.007DB00E@urscorp.com>
Organization: Open Source Development Lab
References: <OFF934C8CA.6C5807E0-ON88256DC1.007CA7CB-88256DC1.007DB00E@urscorp.com>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 16 Oct 2003 15:52:50 -0700
Mike_Phillips@xxxxxxxxxxx wrote:

> 
> > typedef struct ibmtr_dev_t {
> > +    struct tok_info         ti;         /* must be first! */
> 
> Why must this be first ?? Sounds like an alignment issue, we shouldn't
> assume some is aligned correctly just because it's the first entry.

Because ibmtr_cs calls ibmtr_probe1 function which does:
        struct tok_info *ti = dev->priv;
and dereferences it in a couple of places.




<Prev in Thread] Current Thread [Next in Thread>