netdev
[Top] [All Lists]

Re: [PATCH] Fix 64bit warnings in rtl8139too

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: [PATCH] Fix 64bit warnings in rtl8139too
From: Andi Kleen <ak@xxxxxxxxxxxxx>
Date: 14 Oct 2003 21:49:14 +0200
Date: Tue, 14 Oct 2003 21:49:14 +0200
Cc: Andi Kleen <ak@xxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <3F8C3CB0.9090502@pobox.com>
References: <20031007175638.GA1754@averell> <3F8C3CB0.9090502@pobox.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Tue, Oct 14, 2003 at 02:13:04PM -0400, Jeff Garzik wrote:
> Andi Kleen wrote:
> >Fix a harmless 64bit pointer/integer mismatch warning in 8139too.
> >
> >diff -u linux-2.5-cleanup/drivers/net/8139too.c-o 
> >linux-2.5-cleanup/drivers/net/8139too.c
> >--- linux-2.5-cleanup/drivers/net/8139too.c-o        2003-09-08 
> >00:02:03.000000000 +0200
> >+++ linux-2.5-cleanup/drivers/net/8139too.c  2003-12-02 
> >17:13:24.634752560 +0100
> >@@ -746,7 +746,8 @@
> >     u8 tmp8;
> >     int rc;
> >     unsigned int i;
> >-    u32 pio_start, pio_end, pio_flags, pio_len;
> >+    unsigned long pio_start;
> >+    u32 pio_end, pio_flags, pio_len;
> >     unsigned long mmio_start, mmio_end, mmio_flags, mmio_len;
> >     u32 version;
> 
> 
> Why not just make this look like mmio_*?

No problems, feel free to do that.

I just did the minimal change to fix the warning.

-Andi

<Prev in Thread] Current Thread [Next in Thread>